Skip to content

Conversation

pdxlocations
Copy link
Member

This PR adds checking the excluded_modules bitmask in our metadata before getting/setting Ringtone and Canned Messages.

Fixes #814

Copy link

codecov bot commented Aug 30, 2025

Codecov Report

❌ Patch coverage is 45.16129% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.95%. Comparing base (2b10459) to head (7e3d347).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/node.py 25.00% 15 Missing ⚠️
meshtastic/__main__.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
- Coverage   60.11%   59.95%   -0.16%     
==========================================
  Files          24       24              
  Lines        4217     4243      +26     
==========================================
+ Hits         2535     2544       +9     
- Misses       1682     1699      +17     
Flag Coverage Δ
unittests 59.95% <45.16%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jinnatar
Copy link

jinnatar commented Sep 9, 2025

Can confirm that in my tests this does fix #814 for T1000E.

@konimaru
Copy link

Also works for T-Echo. It's a bit puzzling that availability is reported as True when there is no metadata or an exception flies but still better than blocking indefinitely :)

@ianmcorvidae
Copy link
Contributor

Lost track of things, unfortunately as usual. I'll get this one in for now to get things back to working in some fashion, even though I think it can be improved (as you know too, of course).

@ianmcorvidae ianmcorvidae merged commit f519d1f into meshtastic:master Sep 12, 2025
9 of 11 checks passed
@ianmcorvidae
Copy link
Contributor

Oh, heh, this is already the improved fix vs. the last one I looked at, got it confused. Even better! Thanks for that.

@pdxlocations
Copy link
Member Author

All good, I keep meaning to look at what other modules get excluded from firmware builds that we may wish to check for. I think these are main ones. Thanks for the merge and version bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli --config-export can get wedged on parts of the export which blocks the entire export
4 participants